Regex gcc low version error

jianzhu · September 12, 2019, 1:14pm

the latest update to:

dmlc/xgboost/blob/master/src/common/config.h

/*!
 * Copyright 2014-2019 by Contributors
 * \file config.h
 * \brief helper class to load in configures from file
 * \author Haoda Fu, Hyunsu Cho
 */
#ifndef XGBOOST_COMMON_CONFIG_H_
#define XGBOOST_COMMON_CONFIG_H_

#include <xgboost/logging.h>
#include <cstdio>
#include <string>
#include <fstream>
#include <istream>
#include <sstream>
#include <vector>
#include <regex>
#include <iterator>
#include <utility>

This file has been truncated. show original

include following regex related code:
explicit ConfigParser(const std::string& path)
: path_(path),
line_comment_regex_("^#"),
key_regex_(R"rx(^([^#"’=\r\n\t ]+)[\t ]=)rx"),
key_regex_escaped_(R"rx(^(["’])([^"’=\r\n]+)\1[\t ]=)rx"),
value_regex_(R"rx(^([^#"’=\r\n\t ]+)[\t ](?:#.){0,1}$)rx"),
value_regex_escaped_(R"rx(^(["’])([^"’=\r\n]+)\1[\t ](?:#.){0,1}$)rx")
{}

however, these codes cause regex_error exception, when compiled with low version GCC, such as:
gcc (GCC) 4.8.5 20150623 (Red Hat 4.8.5-11)

hcho3 · September 12, 2019, 3:47pm

Indeed, we require GCC 5+, as we’d like to use all features provided by C++11.

jianzhu · September 14, 2019, 5:51am

Thanks a lot, I got it.